Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(box): check for invalid file #5173

Merged
merged 1 commit into from
Mar 10, 2023
Merged

fix(box): check for invalid file #5173

merged 1 commit into from
Mar 10, 2023

Conversation

stevenjoezhang
Copy link
Member

What does it do?

Issue resolved: #5166

const stats = stat(fullpath) returns undefined when fullpath is an invalid symbolic link. Calling stats.isDirectory() breaks the processing of other valid files.

This pull request aims to display an error message indicating the invalid file.

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

@coveralls
Copy link

Coverage Status

Coverage: 98.723% (-0.01%) from 98.733% when pulling b7a8c87 on invalid-file into cb19b29 on master.

@renbaoshuo renbaoshuo added this to the 7.0.0 milestone Mar 10, 2023
@SukkaW SukkaW merged commit 7edbf25 into master Mar 10, 2023
@stevenjoezhang stevenjoezhang deleted the invalid-file branch March 10, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected behavior on github action
4 participants