Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor types #5398

Merged
merged 3 commits into from Jan 23, 2024
Merged

refactor: refactor types #5398

merged 3 commits into from Jan 23, 2024

Conversation

D-Sketon
Copy link
Member

What does it do?

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

Copy link

How to test

git clone -b _type/warehouse https://github.com/D-Sketon/hexo.git
cd hexo
npm install
npm test

@coveralls
Copy link

coveralls commented Jan 19, 2024

Pull Request Test Coverage Report for Build 7594271515

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 99.53%

Totals Coverage Status
Change from base Build 7565611688: 0.005%
Covered Lines: 9312
Relevant Lines: 9356

💛 - Coveralls

Comment on lines +238 to +239
categories: Model<CategorySchema>; // _Model
tags: Model<TagSchema>; // _Model
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after #5388, Model should be Query again

yoshinorin

This comment was marked as resolved.

SukkaW
SukkaW previously approved these changes Jan 19, 2024
uiolee
uiolee previously approved these changes Jan 20, 2024
@D-Sketon D-Sketon dismissed stale reviews from uiolee and SukkaW via b196e76 January 20, 2024 12:12
@D-Sketon
Copy link
Member Author

fix #5403

@D-Sketon D-Sketon linked an issue Jan 20, 2024 that may be closed by this pull request
5 tasks
Copy link
Member

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any would work for now. But IMHO we could use interface merging + theme overloading in the future.

@uiolee uiolee merged commit ee4bc8e into hexojs:master Jan 23, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hexo.theme.config property should not be of type object
5 participants