Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api/rendering): instruction to disable nunjucks #1533

Merged
merged 2 commits into from
Aug 26, 2020

Conversation

curbengh
Copy link
Contributor

Mainly to show example usage of hexo.render.renderer.get() method.
This also can be mentioned in this section #1532.

Check List

Please read and check followings before submitting a PR.

  • I want to publish my theme on Hexo official website.
    • I have read the theme publishing doc.
    • name is unique.
    • link URL is correct.
    • preview URL is correct.
    • preview URL web site is rendered correctly.
    • Add a screenshot to source/themes/screenshots.
    • Screenshot filename is same as value of name.
    • Screenshot size is 800 * 500.
    • Screenshot file format is png.
  • I want to publish my plugin on Hexo official website.
  • Others (Update, fix, translation, etc...)
    • Languages:
    • en English
    • ko Korean
    • pt-br Brazilian Portuguese
    • ru Russian
    • th Thai
    • zh-cn simplified Chinese
    • zh-tw traditional Chinese

@curbengh curbengh requested a review from a team August 25, 2020 02:04
Copy link
Member

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible that the renderer plugin itself can disable the nunjucks. We could add examples for that as well.


P.S. We should add needed disableNunjucks for all official hexo plugins (like hexo-renderer-less, hexo-renderer-styl)

@curbengh
Copy link
Contributor Author

curbengh commented Aug 26, 2020

We could add examples for that as well.

+1, but I'm not familiar with the syntax though.

Edit: added example.

We should add disableNunjucks for all hexo plugins.

Obviously except for template renderer (for anyone else reading this). I can add it and learn the syntax.

@SukkaW SukkaW merged commit 1ce5e11 into hexojs:master Aug 26, 2020
@curbengh curbengh deleted the disable-nunjucks branch August 26, 2020 06:42
@curbengh curbengh restored the disable-nunjucks branch September 17, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants