Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use GitHub actions to sanitize themes & plugins list #2164

Merged
merged 7 commits into from
Apr 15, 2024

Conversation

stevenjoezhang
Copy link
Member

I have improved a script I wrote earlier that can automatically check whether the links for themes and plugins have been updated or become invalid, and it periodically opens a pull request to update them.

See #1458 (comment)

@github-actions github-actions bot added the infra infrastructure, configuration of this repo label Apr 10, 2024
Copy link
Contributor

Theme thumbnails validation completed.

@stevenjoezhang
Copy link
Member Author

We previously discussed the issue of theme preview websites becoming unavailable (in #1941 (comment)), and currently, dozens of theme preview websites are either down or redirected, with some even being maliciously registered due to expired domains.
The main problem now is that it requires a significant amount of manual effort to determine whether these invalid links are due to slow access speeds leading to timeouts, or if they are no longer in use. I was thinking that perhaps we could use the now-discontinued hexojs.github.io domain to deploy preview sites for third-party themes. (See https://github.com/orgs/hexojs/discussions/5409)

@stevenjoezhang
Copy link
Member Author

Another issue is that there are more than 60 repositories of themes or plugins are archived. I suggest that for repositories that are archived or have not been updated for a certain period (for example, 3 years), we need to provide a notice on the hexo.io website that the theme may no longer be available, or just remove them.

.github/workflows/cleaner.yml Show resolved Hide resolved
.github/workflows/cleaner.yml Show resolved Hide resolved
.github/workflows/cleaner.yml Outdated Show resolved Hide resolved
.github/workflows/cleaner.yml Show resolved Hide resolved
.github/workflows/cleaner.yml Outdated Show resolved Hide resolved
Co-authored-by: Uiolee <22849383+uiolee@users.noreply.github.com>
Signed-off-by: Mimi <stevenjoezhang@gmail.com>
@uiolee
Copy link
Member

uiolee commented Apr 10, 2024

use the now-discontinued hexojs.github.io domain to deploy preview sites for third-party themes.

If really necessary, it is better to use the repository page hexojs.github.io/<repo>/. At the same time, code security need to be considered.

theme preview websites becoming unavailable

To avoid this, I recommend that request the authors to use github action to build previews site in their own github page. We can add guide to https://hexo.io/docs/themes#Publishing

.github/workflows/cleaner.yml Show resolved Hide resolved
.github/workflows/cleaner.yml Show resolved Hide resolved
.github/workflows/cleaner.js Outdated Show resolved Hide resolved
stevenjoezhang and others added 3 commits April 14, 2024 12:38
Co-authored-by: Uiolee <22849383+uiolee@users.noreply.github.com>
Signed-off-by: Mimi <stevenjoezhang@gmail.com>
Co-authored-by: Uiolee <22849383+uiolee@users.noreply.github.com>
Signed-off-by: Mimi <stevenjoezhang@gmail.com>
Signed-off-by: Mimi <1119186082@qq.com>
@stevenjoezhang stevenjoezhang merged commit 46652e7 into master Apr 15, 2024
6 checks passed
@stevenjoezhang stevenjoezhang deleted the cleaner branch April 15, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra infrastructure, configuration of this repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants