-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add hexo-theme-ruyun. #2182
Conversation
Theme thumbnails validation completed. |
source/_data/themes/ruyun.yml
Outdated
preview: https://tyzhang.top | ||
tags: | ||
- hexo-theme | ||
- Ruyun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is Ruyun
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ruyun
is name of this theme, search-friendly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. There are no specific provisions regarding the tags to be assigned, but the purpose of the tags is likely to classify content, allowing users to search for themes that match their purposes. Therefore, it is desirable to assign only commonly used tags that may also be used for other themes. Therefore, please remove this tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has now been removed~
source/_data/themes/ruyun.yml
Outdated
- hexo-theme | ||
- Ruyun | ||
- Customizable | ||
- ICP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, this one. What is ICP
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ICP
stands for Internet Content Provider
, which is a licensing system that allows businesses to legally operate online services in China. This theme could config it friendly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked into the ICP license, but it seems that the ICP license is granted (registered) for websites, not for themes, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes,in China, ICP needs to be forced to be displayed at the bottom of the website. This theme will read from the configuration and display it at the bottom as required. This tag will be deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you :)
@ztygalaxy
e.g: https://github.com/ztygalaxy/ztygalaxy.github.io/blob/master/404.html#L516 |
Check List
Please read and check followings before submitting a PR.
name
is unique.link
URL is correct.preview
URL is correct.preview
URL web site is rendered correctly.source/themes/screenshots
.name
.800 * 500
.png
.