Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hexo-theme-ruyun. #2182

Merged
merged 2 commits into from
May 21, 2024
Merged

feat: add hexo-theme-ruyun. #2182

merged 2 commits into from
May 21, 2024

Conversation

ztygalaxy
Copy link
Contributor

@ztygalaxy ztygalaxy commented May 19, 2024

Check List

Please read and check followings before submitting a PR.

  • I want to publish my theme on Hexo official website.
    • I have read the theme publishing doc.
    • name is unique.
    • link URL is correct.
    • preview URL is correct.
    • preview URL web site is rendered correctly.
    • Add a screenshot to source/themes/screenshots.
    • Screenshot filename is same as value of name.
    • Screenshot size is 800 * 500.
    • Screenshot file format is png.

@github-actions github-actions bot added the Themes _data/themes/ label May 19, 2024
Copy link
Contributor

Theme thumbnails validation completed.

preview: https://tyzhang.top
tags:
- hexo-theme
- Ruyun
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is Ruyun?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ruyun is name of this theme, search-friendly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. There are no specific provisions regarding the tags to be assigned, but the purpose of the tags is likely to classify content, allowing users to search for themes that match their purposes. Therefore, it is desirable to assign only commonly used tags that may also be used for other themes. Therefore, please remove this tag.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has now been removed~

- hexo-theme
- Ruyun
- Customizable
- ICP
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this one. What is ICP?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ICP stands for Internet Content Provider, which is a licensing system that allows businesses to legally operate online services in China. This theme could config it friendly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked into the ICP license, but it seems that the ICP license is granted (registered) for websites, not for themes, correct?

Copy link
Contributor Author

@ztygalaxy ztygalaxy May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes,in China, ICP needs to be forced to be displayed at the bottom of the website. This theme will read from the configuration and display it at the bottom as required. This tag will be deleted.

Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@yoshinorin yoshinorin merged commit 00ec066 into hexojs:master May 21, 2024
6 checks passed
@yoshinorin
Copy link
Member

yoshinorin commented May 21, 2024

@ztygalaxy
BTW, it would be better to use https://cdn.mathjax.org instead of http://cdn.mathjax.org in the source code of https://github.com/ztygalaxy/ztygalaxy.github.io. You'll get Mixed Content errors in the browser console otherwise like following.

Mixed Content: The page at 'https://ztygalaxy.github.io/' was loaded over HTTPS, but requested an insecure script 'http://cdn.mathjax.org/mathjax/latest/MathJax.js?config=TeX-AMS-MML_HTMLorMML'. This request has been blocked; the content must be served over HTTPS.

e.g: https://github.com/ztygalaxy/ztygalaxy.github.io/blob/master/404.html#L516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Themes _data/themes/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants