Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add misssing node 10 to ci #44

Merged
merged 2 commits into from
Jun 25, 2019
Merged

add misssing node 10 to ci #44

merged 2 commits into from
Jun 25, 2019

Conversation

tomap
Copy link
Contributor

@tomap tomap commented Jun 9, 2019

  • fix coveralls badge

@tomap
add misssing node 10 to ci
9efa1c8 
+ fix coveralls badge
@tomap
Copy link
Contributor Author

tomap commented Jun 10, 2019

Also, can we publish a new version once this is merged?
There is a loadash vulnerability fixed by a previous PR, but never published

@segayuu
Copy link
Contributor

segayuu commented Jun 13, 2019

I agree with the purpose of this PR.
However, I can not agree to do "this" PR for updating each package.

@tomap
Copy link
Contributor Author

tomap commented Jun 25, 2019

@segayuu : Done :)

@segayuu
Copy link
Contributor

segayuu commented Jun 25, 2019

Thanks @tomap !
LGTM😄

segayuu
segayuu approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@segayuu segayuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@segayuu segayuu merged commit 5e9d53e into hexojs:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@segayuu segayuu segayuu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomap @segayuu