UTF-8 Subdivision names #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the update! I will push an updated gem version out today. |
|
Thanks for the gem! It's awesome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit outputs the proper name of subdivisions instead of the ASCII byte sequence in the yaml files. For example, Rotanokiri was:
R\xC3\xB4t\xC3\xA2n\xC3\xB4kirinow it isRôtânôkiri. This makes it possible to use subdivision names with utf-8 characters in Ruby 1.9.2.The second commit adds the official and locally used abbreviations for provinces in Cambodia. After the conversion all tests still pass and subdivisions are loaded correctly.