Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add postal code knowledge #156

Merged
merged 1 commit into from
Aug 16, 2014
Merged

Add postal code knowledge #156

merged 1 commit into from
Aug 16, 2014

Conversation

maxwell
Copy link
Contributor

@maxwell maxwell commented Jun 23, 2014

I've added a "postal_code" method, which returns a boolean if the given country currently requires postal codes as part of their addresses.

Very scientifically, I took it from this list of [http://en.wikipedia.org/wiki/List_of_postal_codes]

I've also aliased this as zip, zip? postal_code?

aliased as zip, zip? postal_code

based off of info from Wikipedia
[http://en.wikipedia.org/wiki/List_of_postal_codes]
@maxwell
Copy link
Contributor Author

maxwell commented Aug 2, 2014

rebased to current master and resolved merge conflicts. Thanks for taking a look!

@maxwell maxwell mentioned this pull request Aug 2, 2014
@backus
Copy link

backus commented Aug 16, 2014

Could you merge this @hexorx? We've been looking for this functionality in the countries gem and @maxwell's fork seems to work.

hexorx added a commit that referenced this pull request Aug 16, 2014
Add postal code knowledge
@hexorx hexorx merged commit fc0ac93 into countries:master Aug 16, 2014
@backus
Copy link

backus commented Aug 16, 2014

Thanks!

@maxwell
Copy link
Contributor Author

maxwell commented Aug 16, 2014

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants