add find_country_by_name method, use downcase in find methods #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for this gem, it's really great. Just thought I'd let you know about this change I've made. I thought it was a little weird that the
find_by_name
method returned an array containing the country code and then a hash with all the country data. Maybe this was needed for a specific case? I would expect it to return a Country instance. Ideally I'd replace the old method, but I've added a separatefind_country_by_name
method to avoid getting in anyone's way.I also downcased the search term and country name(s) in
find_by_name
to allow for user capitalization mistakes, as I'm pulling in location data from APIs. The usage of this method is unaffected.I had trouble running the tests at first for some reason – I had to resort to specifying the encoding at the top of the file.
Cheers,
Joe