Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

italian and some missing spanish translations #76

Merged
merged 4 commits into from
Jul 10, 2013
Merged

italian and some missing spanish translations #76

merged 4 commits into from
Jul 10, 2013

Conversation

lorenzopagano
Copy link
Contributor

Thank you for this gem!

jrdi
jrdi reviewed Jul 8, 2013
View reviewed changes
lib/data/countries.yaml
de: Kanada
fr: Canada
es:
es: Canada
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lorenzopagano correct translation is Canadá

@jrdi
Copy link
Contributor

jrdi commented Jul 8, 2013

@lorenzopagano I add some comments to spanish translations. Thank you!

@lorenzopagano
Copy link
Contributor Author

;)

hexorx added a commit that referenced this pull request Jul 10, 2013
@hexorx
Merge pull request #76 from lorenzopagano/master
cd66016 
italian and some missing spanish translations
@hexorx hexorx merged commit cd66016 into countries:master Jul 10, 2013
@jrdi
Copy link
Contributor

jrdi commented Jul 11, 2013

@hexorx why do you merge this pull request? It have a lot of mistakes in translations...

@hexorx
Copy link
Collaborator

hexorx commented Jul 11, 2013

I pulled it in so it would be easier to fix the mistakes on the main repo.
If you would now like to submit a pull request with the fixes I can merge
it in. Otherwise I will go through the fixes you commented on and get them
added.

On Thu, Jul 11, 2013 at 12:54 AM, Jordi Villar notifications@github.comwrote:

@hexorx https://github.com/hexorx why you merge this pull request? It
have a lot of mistakes in translations...

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/76#issuecomment-20793478
.

@JoshRobinson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lorenzopagano @jrdi @hexorx