Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tarball metadata file to an erlang term file #41

Closed
4 tasks done
ericmj opened this issue Aug 5, 2014 · 10 comments
Closed
4 tasks done

Change tarball metadata file to an erlang term file #41

ericmj opened this issue Aug 5, 2014 · 10 comments

Comments

@ericmj
Copy link
Member

ericmj commented Aug 5, 2014

  • Support it on the server
  • Bump tarball version support on the client (2014-08-12) (Hex v0.4.1) (Elixir v0.15.0)
  • Build the new tarballs on the client when publishing (2015-02-11) (Hex v0.7.0)
  • Change existing tarballs
@jcspencer
Copy link
Contributor

The main changes we'll need to make to build the new tarballs on the client when publishing are:

  1. Add a case here to add either metadata.exs or metadata.config to the blob to create the checksum
  2. Line 4 and 26 need to changed to support metadata.config
  3. And finally, we need to change Line 19 to build an erlang term file instead of serialized Elixir (this logic has already been completed for hex.config updating)

If this is correct, I'll open a PR. (:+1: or :-1: @ericmj?)

Note: After that, we need to create a job that converts the current tarballs to the new format, and recalculates the checksum both inside the tarball and the registry. I've still got to work out how this will work.

@ericmj
Copy link
Member Author

ericmj commented Aug 29, 2014

This is blocking while we wait for people to upgrade their Elixir versions. It is too early to break Hex for all versions pre 0.15.0.

@jcspencer
Copy link
Contributor

Note: The erlang term file config logic will be implemented after #57

@jcspencer
Copy link
Contributor

This makes sense. Would we be able to push this change at the time Elixir 1.0 comes around?

@jaimerson
Copy link

I think I may have run into this issue. Apparently cowlib, which is a dependency of phoenix framework, only provides metadata.config. I get a ** (Mix) Missing files metadata.exs in /home/jaimerson/.hex/packages/cowlib-1.0.1.tar when trying to install dependencies via mix deps.get. Please disregard this if this has nothing to do with hex, I'm just getting started with elixir.

@josevalim
Copy link
Member

@jaimerson Try running mix local.hex and see if updating your hex version fixes the issue.

@ericmj
Copy link
Member Author

ericmj commented Dec 28, 2014

@jaimerson Should be fixed now.

@jaimerson
Copy link

Ok, working now, thank you, guys 😉

@jcspencer
Copy link
Contributor

@ericmj Are we now able to convert existing v2 tarballs to the new v3 format, or are we still waiting for more adoption?

@ericmj
Copy link
Member Author

ericmj commented Mar 2, 2015

@jcspencer It can be done now, I just need to get some time over to do the actual migration.

@ericmj ericmj closed this as completed Apr 26, 2015
kianmeng pushed a commit to kianmeng/hex that referenced this issue Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants