Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return size when package exceeds max size #103

Merged
merged 1 commit into from Oct 19, 2020
Merged

Return size when package exceeds max size #103

merged 1 commit into from Oct 19, 2020

Conversation

starbelly
Copy link
Contributor

@starbelly starbelly mentioned this pull request Oct 19, 2020
Merged
ericmj
ericmj approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@ericmj ericmj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💜

@starbelly
Return size when package exceeds max size
aa40f91 
 - change error tuple in hex_tarball:create/2 to include an identifiable
 atom and size respective to compressed or uncompressed max size exceeded.
@starbelly starbelly force-pushed the return-size-on-tarball-too-big branch from a3be8fa to aa40f91 Compare October 19, 2020 19:43
@wojtekmach wojtekmach merged commit 91fcf65 into hexpm:master Oct 19, 2020
@wojtekmach
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericmj ericmj ericmj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hex_tarball enhancment: Report max size in error or provide functions to obtain max size(s)
3 participants
@starbelly @wojtekmach @ericmj