Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Red border and Exclamation point icon for validation errors and check icon for correctly filled inputs #1088

Conversation

TraceyOnim
Copy link

No description provided.

@apply italic font-medium text-sm text-red-600;
}

.form-input-error {
@apply border-red-600;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected RBRACE at line 24, col 5.

@apply italic font-medium text-sm text-red-600;
}

.form-input-error {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule is empty.

}

.form-input-error {
.form-error {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule is empty.

@TraceyOnim TraceyOnim changed the title Authentication/add styling for validation errors Display Red border and Exclamation point icon for validation errors and check icon for correctly filled inputs Dec 6, 2021
Copy link
Member

@ericmj ericmj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The green border is missing around fields where validation passed.

lib/hexpm_web/views/view_helpers.ex Outdated Show resolved Hide resolved
lib/hexpm_web/views/view_helpers.ex Outdated Show resolved Hide resolved
lib/hexpm_web/templates/signup/show.html.eex Outdated Show resolved Hide resolved
lib/hexpm_web/templates/signup/show.html.eex Outdated Show resolved Hide resolved
assets/css/components/general.css Outdated Show resolved Hide resolved
TraceyOnim and others added 5 commits December 7, 2021 20:10
Co-authored-by: sourcelevel-bot[bot] <23344435+sourcelevel-bot[bot]@users.noreply.github.com>
Co-authored-by: Eric Meadows-Jönsson <eric.meadows.jonsson@gmail.com>
Co-authored-by: Eric Meadows-Jönsson <eric.meadows.jonsson@gmail.com>
Co-authored-by: Eric Meadows-Jönsson <eric.meadows.jonsson@gmail.com>
Co-authored-by: Eric Meadows-Jönsson <eric.meadows.jonsson@gmail.com>
@TraceyOnim
Copy link
Author

The green border is missing around fields where validation passed.

I'm adding styling for that

@ericmj ericmj merged commit 7ac3d71 into hexpm:redesign Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants