Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong detection browser version of Safari browser. #4

Closed
ivankuraev opened this issue Jan 11, 2024 · 1 comment
Closed

Wrong detection browser version of Safari browser. #4

ivankuraev opened this issue Jan 11, 2024 · 1 comment
Assignees
@hexydec
Labels
bug Something isn't working

Comments

@ivankuraev
Copy link

Hello.

Wrong detection browser version of Safari browser.

For example,
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.4 Safari/605.1.15

browserversion is should be 15.4, but detect 605.1.15.
@hexydec hexydec self-assigned this Jan 11, 2024
@hexydec hexydec added the bug Something isn't working label Jan 11, 2024
hexydec added a commit that referenced this issue Jan 11, 2024
@hexydec
Fixed issue #4 where the browser version of Safari is defined in a …
1519358 
…different token most of the time, it now extracts that value, and falls back to the version specified in the `safari/xxx` token.

Updated `phpunit.xml` to take the whole tests directory rather than specifying each file.
Updated dependencies.
@hexydec
Copy link
Owner

hexydec commented Jan 11, 2024

Thanks for letting me know about this. I have updated the code to correctly detect the version now.

@hexydec hexydec closed this as completed Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hexydec hexydec

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hexydec @ivankuraev