Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider dual publishing commonjs #405

Closed
Stono opened this issue Apr 17, 2024 · 4 comments · Fixed by #409
Closed

Consider dual publishing commonjs #405

Stono opened this issue Apr 17, 2024 · 4 comments · Fixed by #409
Assignees
Labels
bug 🔥 Something isn't working

Comments

@Stono
Copy link
Contributor

Stono commented Apr 17, 2024

Description

Hi,
So you've recently made this module ESM only.

Whilst I support the general move towards ESM; realistically moving our entire estate to support ESM is a mammoth task. The way that unfortunately manifests for me is that I'll either need to fork this module and make it non-esm, or find an alternative (or write my own), because I don't see us managing to migrate an entire legacy estate to support esm any time soon.

Appreciate you may not want to do this, if so please just close the issue and i'll have my answer and know which direction I need to take :)

OpenAPI specification (optional)

No response

Configuration

No response

System information (optional)

No response

@mrlubos
Copy link
Member

mrlubos commented Apr 17, 2024

Nope, I think we will want this @Stono 🤝 interestingly, you're the only one who complained so far, I was expecting more reports sooner

@jordanshatford
Copy link
Collaborator

@Stono Would you be able to help out with this. Or provide a repository for reproduction. Unfortunately I do not think my initial fix will solve this

@jordanshatford
Copy link
Collaborator

Have pushed changes which I was able to test and appear to fix this issue. Was able to properly generate with both CJS and ESM, when before my changes it would fail with CJS

@mrlubos
Copy link
Member

mrlubos commented Apr 18, 2024

@Stono This should be now fixed, can you give it a try? Awesome work @jordanshatford 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🔥 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants