Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[methodNameBuilder] KO without asClass: true, #762

Closed
Kalshu opened this issue Jul 9, 2024 · 4 comments · Fixed by #781
Closed

[methodNameBuilder] KO without asClass: true, #762

Kalshu opened this issue Jul 9, 2024 · 4 comments · Fixed by #781
Labels
bug 🔥 Something isn't working

Comments

@Kalshu
Copy link

Kalshu commented Jul 9, 2024

Description

Hello,

My method for generating a custom name is not used by the generator when the service's asClass property is not set.

Is this the desired behavior?

I have to use this method because the native generation, which is based on a swagger that I don't control directly, uses reserved words (like "delete").

Reproducible example or configuration

https://stackblitz.com/edit/hey-api-client-fetch-example-generatorname?file=openapi-ts.config.ts

OpenAPI specification (optional)

No response

System information (optional)

No response

@Kalshu Kalshu added the bug 🔥 Something isn't working label Jul 9, 2024
Copy link

stackblitz bot commented Jul 9, 2024

@mrlubos
Copy link
Member

mrlubos commented Jul 9, 2024

Hey @Kalshu, yes that sounds about right. Will fix, thanks for reporting.

@mrlubos
Copy link
Member

mrlubos commented Jul 17, 2024

@Kalshu this is now fixed!

@Kalshu
Copy link
Author

Kalshu commented Jul 17, 2024

@Kalshu this is now fixed!

I see that, thanks !
I see you also fix the generation with reserved keyword, really great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🔥 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants