Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: comment position in JavaScript enums #544

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

mrlubos
Copy link
Contributor

@mrlubos mrlubos commented May 7, 2024

Closes #542

Copy link

stackblitz bot commented May 7, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented May 7, 2024

🦋 Changeset detected

Latest commit: 2554fde

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mrlubos mrlubos marked this pull request as ready for review May 7, 2024 00:58
Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 1:02am

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.98%. Comparing base (2dc60f2) to head (2554fde).

Files Patch % Lines
packages/openapi-ts/src/utils/write/types.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #544   +/-   ##
=======================================
  Coverage   75.98%   75.98%           
=======================================
  Files          75       75           
  Lines        6743     6743           
  Branches      642      642           
=======================================
  Hits         5124     5124           
  Misses       1616     1616           
  Partials        3        3           
Flag Coverage Δ
unittests 75.98% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlubos mrlubos merged commit 04f31ff into main May 7, 2024
15 of 16 checks passed
@mrlubos mrlubos deleted the chore/enum-comments branch May 7, 2024 01:10
@github-actions github-actions bot mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shift comment position on enums
2 participants