Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow typescript dependency in peerDependencies #551

Merged
merged 5 commits into from
May 13, 2024

Conversation

Maggi64
Copy link
Contributor

@Maggi64 Maggi64 commented May 8, 2024

My package.json looks like this. The api-client package a local yarn workspace package in this case. Typescript is supplied via a root package.json file in a parent directory and is available this way.

This MR allows these kinds of setups without throwing an error:

{
  "name": "api-client",
  "private": true,
  "scripts": {...},
  "devDependencies": {
    "@hey-api/openapi-ts": "0.43.2",
    "js-cookie": "3.0.5"
  },
  "peerDependencies": {
    "axios": ">=1.6.5",
    "typescript": ">=5.4.5"
  }
}

Copy link

stackblitz bot commented May 8, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented May 8, 2024

🦋 Changeset detected

Latest commit: 608f9d8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 11:12am

@Maggi64 Maggi64 changed the title Search for typescript dependency in peerDependencies Allow typescript dependency in peerDependencies May 8, 2024
Copy link
Contributor

@mrlubos mrlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you!

EDIT: Apart from the linter fail ha

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.99%. Comparing base (04f31ff) to head (6c5d03a).

❗ Current head 6c5d03a differs from pull request most recent head 608f9d8. Consider uploading reports for the commit 608f9d8 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #551   +/-   ##
=======================================
  Coverage   75.98%   75.99%           
=======================================
  Files          75       75           
  Lines        6743     6744    +1     
  Branches      642      642           
=======================================
+ Hits         5124     5125    +1     
  Misses       1616     1616           
  Partials        3        3           
Flag Coverage Δ
unittests 75.99% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Maggi64
Copy link
Contributor Author

Maggi64 commented May 10, 2024

Should be fixed now 👍

@mrlubos mrlubos merged commit e8ba13e into hey-api:main May 13, 2024
2 checks passed
@github-actions github-actions bot mentioned this pull request May 13, 2024
@mrlubos
Copy link
Contributor

mrlubos commented May 13, 2024

This is fixed in v0.44.0, thanks @Maggi64!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants