Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle application/json content type in parameter definitions #614

Merged
merged 1 commit into from
May 23, 2024

Conversation

mrlubos
Copy link
Contributor

@mrlubos mrlubos commented May 23, 2024

Closes #612

Copy link

stackblitz bot commented May 23, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 2:14pm

Copy link

changeset-bot bot commented May 23, 2024

🦋 Changeset detected

Latest commit: 93adfc3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 95.40230% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 75.46%. Comparing base (0ac9401) to head (93adfc3).

Files Patch % Lines
...ages/openapi-ts/src/openApi/v3/parser/getModels.ts 62.50% 3 Missing ⚠️
...ages/openapi-ts/src/openApi/v3/parser/parameter.ts 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #614      +/-   ##
==========================================
+ Coverage   75.38%   75.46%   +0.07%     
==========================================
  Files          74       75       +1     
  Lines        7231     7270      +39     
  Branches      653      660       +7     
==========================================
+ Hits         5451     5486      +35     
- Misses       1777     1781       +4     
  Partials        3        3              
Flag Coverage Δ
unittests 75.46% <95.40%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlubos mrlubos marked this pull request as ready for review May 23, 2024 14:07
@mrlubos mrlubos merged commit 05b1200 into main May 23, 2024
16 checks passed
@mrlubos mrlubos deleted the fix/client-beta-3 branch May 23, 2024 14:18
@github-actions github-actions bot mentioned this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameters with in: header cause incompatible types
1 participant