Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export type RequestResult of fetch client #698

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

lsdch
Copy link
Contributor

@lsdch lsdch commented Jun 19, 2024

This aims to improve usability of generated fetch clients. Fixes #693

Copy link

stackblitz bot commented Jun 19, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Jun 19, 2024

🦋 Changeset detected

Latest commit: fc2b166

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hey-api/client-fetch Patch
@example/openapi-ts-fetch Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jun 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 1:04pm

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.89%. Comparing base (032bd93) to head (fc2b166).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #698   +/-   ##
=======================================
  Coverage   70.89%   70.89%           
=======================================
  Files          76       76           
  Lines        7984     7984           
  Branches      696      696           
=======================================
  Hits         5660     5660           
  Misses       2321     2321           
  Partials        3        3           
Flag Coverage Δ
unittests 70.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mrlubos mrlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create a patch changeset please?

@lsdch
Copy link
Contributor Author

lsdch commented Jun 19, 2024

@mrlubos Sure, just added it!

@mrlubos mrlubos merged commit 4ded70a into hey-api:main Jun 19, 2024
16 checks passed
@lsdch
Copy link
Contributor Author

lsdch commented Jun 20, 2024

@mrlubos Hey, this PR was actually ineffectual: the type is still made private after going through rollup. I force-pushed a fix on the same branch and made sure it builds as expected.

Apologies for my mistake... Please let me know if I should open a new PR

@mrlubos
Copy link
Contributor

mrlubos commented Jun 20, 2024

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@hey-api/client-fetch: TS type RequestResult is not exported
2 participants