Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle properties in one-of composition #745

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

mrlubos
Copy link
Contributor

@mrlubos mrlubos commented Jul 4, 2024

Closes #713

Copy link

stackblitz bot commented Jul 4, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Jul 4, 2024

🦋 Changeset detected

Latest commit: 342772a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jul 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2024 0:35am

@mrlubos mrlubos marked this pull request as ready for review July 4, 2024 00:35
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.59%. Comparing base (88f79bf) to head (342772a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #745      +/-   ##
==========================================
+ Coverage   73.53%   73.59%   +0.06%     
==========================================
  Files          78       78              
  Lines        8298     8318      +20     
  Branches      770      770              
==========================================
+ Hits         6102     6122      +20     
  Misses       2192     2192              
  Partials        4        4              
Flag Coverage Δ
unittests 73.59% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlubos mrlubos merged commit 0e14810 into main Jul 4, 2024
16 checks passed
@mrlubos mrlubos deleted the fix/one-of-composition-properties branch July 4, 2024 00:42
@github-actions github-actions bot mentioned this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect type generated when combining oneOf with properties
1 participant