feat(header): enhanced information sent to tracking function #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added a lot more information to the tracking function to help i15 meet their tracking requirements HEYUI-350
nathanjamal
commented
May 31, 2023
| @@ -102,7 +102,12 @@ const Header = React.forwardRef<HTMLElement, HeaderProps>( | |||
| aria-label={locale.logoLabel} | |||
| className={styles.logo} | |||
| href={logoHref} | |||
| onClick={() => itemOnClick('Logo', trackingFn)} | |||
| onClick={() => | |||
| itemOnClick({ | |||
There was a problem hiding this comment.
Tracking is now sent with an object of values, not just a label
Pull Request Test Coverage Report for Build 5133953363
💛 - Coveralls |
|
Compiled a new version demo. |
Coverage report
Show files with reduced coverage 🔻
Test suite run success377 tests passing in 53 suites. Report generated by 🧪jest coverage report action from 75a9b58 |
esraltintas
approved these changes
Jun 1, 2023
supcar
pushed a commit
that referenced
this pull request
Jun 1, 2023
# [8.5.0](v8.4.1...v8.5.0) (2023-06-01) ### Features * **header:** enhanced information sent to tracking function ([#214](#214)) ([eeae6be](eeae6be))
|
🎉 This PR is included in version 8.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
added a lot more information to the tracking function to help i15 meet their tracking requirements
HEYUI-350
Type of change
How do I test this
Checklist
Did you remember to take care of the following?
npm i– for new NPM dependencies.npm run lint- to check for linting issuesnpm run test- to run unit testsnpm run test:sh:docker- to run screenshot tests, detail instructionNew Feature / Bug Fix
Thanks for contributing!