Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intent to use bigint/numeric union #959

Closed
namm356 opened this issue Feb 25, 2021 · 5 comments
Closed

Intent to use bigint/numeric union #959

namm356 opened this issue Feb 25, 2021 · 5 comments

Comments

@namm356
Copy link

namm356 commented Feb 25, 2021

No description provided.

@annevk
Copy link
Member

annevk commented Feb 25, 2021

Where?

@fdwr
Copy link

fdwr commented Feb 17, 2024

We have 3 use cases in WebNN where we need to be able to accept full precision from the API and retain it passed all the way down to the bottom, because float64 cannot express the full precision of int64.

Since this issue is closed, should I open a new one, per the wording here that @inexorabletash pointed out?

https://webidl.spec.whatwg.org/#limit-bigint-numeric-unions

It would not be appropriate to accept such a union, only to then convert values of the numeric type to a bigint for further processing, as this runs the risk of introducing precision errors. Please file an issue before using this feature.

@inexorabletash
Copy link
Member

inexorabletash commented Feb 17, 2024

I expect it was a bot clicking on the link in WebIDL that caused this specific issue to be opened. But for WebNN we've got a real case now! We can either recycle this issue or create a new one, whatever the WebIDL maintainers prefer. Tagging @annevk just in case.

@annevk
Copy link
Member

annevk commented Feb 17, 2024

A new issue would be good, thanks!

@fdwr
Copy link

fdwr commented Feb 17, 2024

A new issue would be good, thanks!

👍 #1388

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants