Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct requirement to define Global properties on the object itself #639

Merged
merged 1 commit into from
Feb 6, 2019

Conversation

Ms2ger
Copy link
Member

@Ms2ger Ms2ger commented Feb 6, 2019

The specification required defining the operations and attributes for the Global
interface itself as well as its inherited interfaces on the object itself.

This is not implemented in Gecko, Chrome or WebKit: none of these engines
defines, for example, the addEventListener method on the window object.

I suspect this text was meant to refer to mixin interfaces rather than
inherited interfaces, but these are already covered by a catch-all statement.


Preview | Diff

The specification required defining the operations and attributes for the Global
interface itself as well as its inherited interfaces on the object itself.

This is not implemented in Gecko, Chrome or WebKit: none of these engines
defines, for example, the `addEventListener` method on the window object.

I suspect this text was meant to refer to mixin interfaces rather than
inherited interfaces, but these are already covered by a catch-all statement.
Copy link
Collaborator

@bzbarsky bzbarsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@bzbarsky bzbarsky merged commit fc5da8f into master Feb 6, 2019
@Ms2ger Ms2ger deleted the global-own-props branch February 6, 2019 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants