Clarify object creation in named constructors #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the text for normal constructors. I forgot to update this algorithm in 8e1b529.
annevk
reviewed
Feb 25, 2019
| Rethrow any exceptions. | ||
| 1. Let |O| be the result of [=converted to an ECMAScript value|converting=] |object| | ||
| to an ECMAScript [=interface type=] value |I|. | ||
| 1. Assert: |O| is an object that implements |I|. |
There was a problem hiding this comment.
There's no formal definition yet; I'm planning to add one soon, though.
index.bs
Outdated
| 1. Let |O| be the result of [=converted to an ECMAScript value|converting=] |object| | ||
| to an ECMAScript [=interface type=] value |I|. | ||
| 1. Assert: |O| is an object that implements |I|. | ||
| 1. Assert: |O|.\[[Realm]] is equal to |realm|. |
index.bs
Outdated
| 1. Perform the actions listed in the description of |constructor| | ||
| with |values| as the argument values | ||
| and |object| as the <emu-val>this</emu-val> value. | ||
| Rethrow any exceptions. |
annevk
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the text for normal constructors. I forgot to update this
algorithm in 8e1b529.
Preview | Diff