Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify the relation between the secure context definitions. #785

Merged
merged 1 commit into from
Sep 2, 2019
Merged

Clarify the relation between the secure context definitions. #785

merged 1 commit into from
Sep 2, 2019

Conversation

Ms2ger
Copy link
Member

@Ms2ger Ms2ger commented Aug 30, 2019 •
edited by pr-preview bot
Loading

domenic
domenic approved these changes Aug 30, 2019
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I might tweak it by merging the two paragraphs: "if it is not available only in secure contexts (i.e., if no [SecureContext] extended attribute applies to it)."

@Ms2ger Ms2ger merged commit fa38f6c into master Sep 2, 2019
@Ms2ger Ms2ger deleted the secure-contexts branch September 2, 2019 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ms2ger @domenic