Tweak async iterator algorithms #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 24, 2019
Ms2ger
approved these changes
Sep 24, 2019
index.bs
Outdated
| The [=async iterator initialization steps=] for a <code class="idl">SessionManager</code> | ||
| async iterator |iterator| are: | ||
|
|
||
| 1. Set |iterator|'s current state to "not yet started". |
There was a problem hiding this comment.
Should "current state" be xreffed like https://heycam.github.io/webidl/#environment-ready-promise ?
There was a problem hiding this comment.
Yeah, that's probably a good idea; I'll push that tweak tomorrow before merging.
domenic
force-pushed
the
async-iterator-no-current-state
branch
from
c14701b
to
1ca64bd
Compare
|
@Ms2ger I force-pushed a revised commit. I realized I forgot to actually update the call sites of the algorithm, so the changes were more substantial. In particular I replaced the "state" definition with an "is finished" boolean in the ES binding. As such a new re-review would be appreciated. |
|
I've also pushed a commit that allows "get the next iteration result" to reject to fix #803, since it was so small. |
Make both the "async iterator initialization steps" and the "get the next iteration result" take two arguments: the instance, and the async iterator. This ends up being more ergonomic than using the "current state" concept.
domenic
force-pushed
the
async-iterator-no-current-state
branch
from
21fa354
to
0af9c61
Compare
Ms2ger
reviewed
Oct 11, 2019
* Export the terms we expect people to use * Highlight the samples as Web IDL * Clean up the description of the initialization steps * Simplify the algorithm for next a bit
domenic
force-pushed
the
async-iterator-no-current-state
branch
from
0af9c61
to
2d6954b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make both the "async iterator initialization steps" and the "get the next iteration result" take two arguments: the instance, and the async iterator. This ends up being more ergonomic than using the "current state" concept.
Preview | Diff