Add async value iterators and async iterator arguments #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
commented
Sep 27, 2019
domenic
force-pushed
the
async-value-iterators
branch
from
d424411
to
719a360
Compare
Ms2ger
reviewed
Oct 24, 2019
domenic
force-pushed
the
async-value-iterators
branch
from
719a360
to
8cd2cd6
Compare
domenic
changed the title
This comment has been minimized.
This comment has been minimized.
domenic
force-pushed
the
async-value-iterators
branch
from
8cd2cd6
to
bba882b
Compare
|
Rebased on master, made LL(1), and ready for review! |
|
Ping on reviews? |
ExE-Boss
reviewed
Apr 1, 2020
Comment on lines
+4301
to
4303
| async iterable<value_type>; | ||
| async iterable<value_type>(/* arguments... */); | ||
| async iterable<key_type, value_type>; |
There was a problem hiding this comment.
This should probably also be listed, given that it's valid:
async iterable<key_type, value_type>(/* arguments... */);
11 tasks
EdgarChen
approved these changes
Apr 21, 2020
index.bs
Outdated
| @@ -12655,8 +12725,16 @@ The \[[Prototype]] [=internal slot=] of an [=asynchronous iterator prototype obj | |||
| 1. Set |object|'s [=default asynchronous iterator object/is finished=] to true. | |||
| 1. Return [=!=] [$CreateIterResultObject$](<emu-val>undefined</emu-val>, | |||
| <emu-val>true</emu-val>). | |||
| 1. Otherwise: | |||
| 1. Otherwise, if the corresponding [=asynchronously iterable declaration=] is a | |||
There was a problem hiding this comment.
We have interface defined in step 1,
- Let interface be the interface for which the asynchronous iterator prototype object exists.
could we use something like if interface has a pair asynchronously iterable declaration instead?
index.bs
Outdated
| 1. Return the [=iterator result=] for |next| and |kind|. | ||
| 1. Otherwise: | ||
| 1. Assert: the corresponding [=asynchronously iterable declaration=] is a |
|
Thanks for the review! Code review comments addressed, plus removed an extra clause that I saw in my own re-review. |
This was referenced Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #800.
Preview | Diff