Add missing terminals to Other and ArgumentNameKeyword (#813)

[bathos]

See #813.

---

Preview | Diff

[Ms2ger]

@bzbarsky ?

I wonder if we could lint for this.

[bathos]

You mentioned on #815:

At the very least, we should import that code into this repo. I wouldn't mind seeing it rewritten in python either, but that's not urgent.

I’d be happy to have a go at both integrating the postprocessor code and adding a test to check-grammar* that confirms that Other describes the set of all terminals save the seven intended exceptions. Even if they don’t share code directly, they would benefit from a bit more uniformity since they are doing very similar things. However I’d like to do so as part of a more general effort to clean the build and test scripts and, in particular, to make them platform agnostic.

Aside from the deploy script, the platform assumptions currently made seem to be avoidable. I’m on windows, so I already had to write a js equiv of the makefile to jump the initial barrier to participation, and I could polish/share that.

It would also be nice to surface this stuff more clearly. I don’t think it’s really evident that tests exist, nor is it obvious how to run locally.

I’m afraid though that if I do this, stuff will either remain JS or, in the case of bash stuff, become JS 😱. My Python is pretty limited.

* I now see this script repeats the "float" issue from #815, which might hint that there are additional worthwhile grammar checks that are missing.

[bzbarsky]

That looks reasonable, thank you!

We could try linting for this, but that would mean having the lint find all the terminals somehow.

[bathos]

@bzbarsky

The check-grammar.js script uses syntax-cli’s Grammar class —

https://github.com/heycam/webidl/blob/4203404f78d72d448d7d32c563733a35fa99b0ac/check-grammar.js#L40

— which exposes methods like getTerminals()

I haven’t dug in enough to say for sure, but it appears that the syntax-cli module provides the grammar introspection tools which would be needed to perform the test.