Named properties object: enumerate supported properties in [[OwnPropertyKeys]] #964
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Gecko implements proposed
[[OwnPropertyKeys]]
semantics, but Blink and WebKit do not.This PR feels like an expected behavior and aligns named properties object with legacy platform objects on enumerating supported property names.
Since only
Window
has named properties object, and it also has aLegacyUnenumerableNamedProperties
extended attribute, this change has no performance impact onfor (var k in window) {}
.If this is feasible to implement in Blink, I will contribute extensive WPT coverage and author a patch for WebKit. Once #963 and
[[OwnPropertyKeys]]
discrepancies are resolved,WindowProperties
will be 100% compatible across all implementations!