Add comprehensive coverage for WindowProperties object #27970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll hold off on reviewing this until we settle whatwg/webidl#963; please ping for re-review if I don't get to it then! |
shvaikalesh
force-pushed
the
named-properties-object-allow-symbols
branch
from
a89845b
to
b96e64b
Compare
|
@domenic Hey, I've decided not to pursue the spec changes and updated this PR to match the current spec. Although these tests were already approved by a WebKit reviewer, I was hoping you could take a look as well? |
domenic
reviewed
May 18, 2021
html/browsers/the-window-object/named-access-on-the-window-object/window-named-properties.html
Show resolved
Hide resolved
domenic
approved these changes
May 18, 2021
There was a problem hiding this comment.
LGTM. Shall we close whatwg/webidl#963 and file bugs on Blink and Gecko?
|
Thank you for reviewing this Domenic! I've closed the issue and filed implementation bugs: |
shvaikalesh
commented
May 20, 2021
| var names = Object.getOwnPropertyNames(gsp); | ||
| assert_equals(names.filter((name) => name == "baz").length, 1); | ||
|
|
||
| assert_equals(gsp.baz, document.getElementsByTagName("iframe")[1]); |
There was a problem hiding this comment.
Oops, this is wrong. #29063
shvaikalesh
added a commit
that referenced
this pull request
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation bugs
This PR tests exclusively the current spec for named properties object.
Gecko (tested on Firefox Dev 89.0b14):
[[GetOwnProperty]]doesn't return supported properties that are indices.Reflect.setandReflect.definePropertyincorrectly throwTypeErrorin case of failure.[[OwnPropertyKeys]]is not an ordinary method.Blink (tested on Chrome 92.0.4512.0):
[[DefineOwnProperty]]doesn't fail for string keys, allowing expando properties.[[DefineOwnProperty]]doesn't fail for symbols.Reflect.definePropertyincorrectly returnstruefor string properties (supported & not).[[Get]]fails to perform named property visibility algorithm for supported indexed properties.[[Set]]doesn't fail for symbols.Reflect.setincorrectly returntruefor string properties (supported & not).[[Delete]]doesn't fail for symbols.WebKit: all passing with bug #222918.