Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#159 #161 Refactoring sectors to include type & kind, Adding property address fields & refactoring #162

Merged
merged 7 commits into from
Dec 1, 2019

Conversation

JamalG16
Copy link
Collaborator

@JamalG16 JamalG16 commented Nov 30, 2019

PR includes #159 #161

  • Renaming sector type table to sectors
  • Include sector KIND in the sectors table
  • Create a new table called property_sectors which links properties and their respective sectors
  • Refactoring taking the above into account

AND

  • Adding country code, city, postal code and province to property
  • Refactoring with the above changes

Some refactoring was done to fix lint issues that were already present

@JamalG16 JamalG16 changed the title #159 #161 Sector kind and property address fields #159 #161 Refactoring sectors to include type & kind, Adding property address fields & refactoring Nov 30, 2019
Copy link
Owner

@heyhellomila heyhellomila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no GIFs today, as I am reviewing this on an another PC device. There are small changes we should verify with @MinhThangle in terms of furniture & appliances being lumped together. As well, we should change the country code to ISO code standards (if this app wants to expand to other french speaking countries).

Copy link
Collaborator

@daniakalomiris daniakalomiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great! Just need to change one small thing when specifying the sector kind in the work order query.

Copy link
Owner

@heyhellomila heyhellomila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems good, and updated per @MinhThangle ’s request.
DD2D98A0-7F08-4B2A-9A5C-EDCE62E5CCCA

@JamalG16 JamalG16 merged commit c360413 into master Dec 1, 2019
@JamalG16 JamalG16 deleted the issue-159-sector-kind branch December 1, 2019 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants