-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#159 #161 Refactoring sectors to include type & kind, Adding property address fields & refactoring #162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no GIFs today, as I am reviewing this on an another PC device. There are small changes we should verify with @MinhThangle in terms of furniture & appliances being lumped together. As well, we should change the country code to ISO code standards (if this app wants to expand to other french speaking countries).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great! Just need to change one small thing when specifying the sector kind in the work order query.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems good, and updated per @MinhThangle ’s request.
PR includes #159 #161
AND
Some refactoring was done to fix lint issues that were already present