Refactor

- update typings for generator "as" - add missing return types for createComponents, flexCol
heyjul3s · Feb 11, 2021 · 015761f · 015761f
1 parent 83e25b1
commit 015761f
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/packages/component-generator/src/createComponents.tsx b/packages/component-generator/src/createComponents.tsx
@@ -70,7 +70,7 @@ export function generateComponent<
 >(
   base: BaseConfig<Props, AllHTMLAttributes<Element>, ThemeType>,
   setting: Settings<Element>
-) {
+): React.FC<Props> {
   return createStyledComponent<Props, ThemeType, AllHTMLAttributes<Element>>({
     ...base,
     styles: { ...base.styles, ...setting },

diff --git a/packages/component-generator/src/createStyledComponent.tsx b/packages/component-generator/src/createStyledComponent.tsx
@@ -31,7 +31,7 @@ export function createStyledComponent<
 
 export function createStyled<Props = void, Theme = void, Attributes = void>(
   config: BaseConfig<Props, Attributes, Theme>
-) {
+): React.FC<Props> {
   return pipe(
     createStyledElement,
     createStyledAttributes,

diff --git a/packages/component-generator/src/typings.ts b/packages/component-generator/src/typings.ts
@@ -61,7 +61,7 @@ export type ComponentsRecord<Dict, Props, ThemeType> = {
 
 export type Settings<Element = HTMLDivElement> = {
   [key: string]: ScalableCSS & {
-    as?: string;
+    as?: keyof JSX.IntrinsicElements;
     attrs?: AllHTMLAttributes<Element>;
   };
 };
diff --git a/packages/flex/src/FlexCol.tsx b/packages/flex/src/FlexCol.tsx
@@ -66,7 +66,7 @@ export function setGutterWidth(
     : `${(gutterWidth as number) / 2}em`;
 }
 
-export function parseNumberToTwoDecimals(value: number) {
+export function parseNumberToTwoDecimals(value: number): string {
   return `${parseFloat(String(value)).toFixed(2)}`;
 }