Update pxToEm

- Additional check for finite values for pxToEm - Additional test case for Infinity numeric value
heyjul3s · Feb 10, 2021 · fee58bc · fee58bc
1 parent 0fc803d
commit fee58bc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/packages/pxtoem/__tests__/pxtoem.test.ts b/packages/pxtoem/__tests__/pxtoem.test.ts
@@ -12,6 +12,10 @@ describe('@artifak/pxtoem', () => {
     expect(pxToEm(NaN as any)).toEqual('0em');
   });
 
+  it('returns a string of "0em" when provided with Infinity as value', () => {
+    expect(pxToEm(Infinity)).toEqual('0em');
+  });
+
   it('returns a string EM value of 3 when provided a numeric value of "48"', () => {
     expect(pxToEm(48)).toEqual('3em');
   });

diff --git a/packages/pxtoem/src/pxtoem.ts b/packages/pxtoem/src/pxtoem.ts
@@ -10,7 +10,7 @@ export function getPxNumericValue(size: number | string): number {
     return extractPxNumericValue(size as string);
   }
 
-  if (!!size) {
+  if (!!size && isFinite(size as number)) {
     return size as number;
   }