Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/generator #27

Merged
merged 18 commits into from
Dec 23, 2020
Merged

Refactor/generator #27

merged 18 commits into from
Dec 23, 2020

Conversation

heyjul3s
Copy link
Owner

Generator Refactor and other fixes

  • update dependencies to latest across all packages
  • fix SC hooks error due to possible differinng react versions via resolutions
  • refactor generator package
  • update Block and Typography package to use new generator API

- return FC instead of StyledComponent to support scaled style values
- replace createStyledFunctionComponent with createStyledComponent to support base style overrides
- remove attrs params from createBaseCompoents
- update Block to use new API
- update Block storybook
- update Typography to use new generator API
- split to 2 params for createBaseComponents
- remove unused mocks
- tests
- export updates
- update to use new Generator API
- udpate tests
- update exports
- remove unused mocks
@heyjul3s heyjul3s self-assigned this Dec 23, 2020
@changeset-bot
Copy link

changeset-bot bot commented Dec 23, 2020

⚠️ No Changeset found

Latest commit: ea2ae43

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@heyjul3s heyjul3s merged commit 7e43ecf into develop Dec 23, 2020
@heyjul3s heyjul3s deleted the refactor/generator branch December 23, 2020 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant