Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-navigation): upgrade to react navigation v6 #109

Merged

Conversation

pedpess
Copy link
Collaborator

@pedpess pedpess commented Oct 6, 2021

Description

This PR does the following:

  • Update to React Navigation v6
  • Type LinkingConfiguration with LinkingOptions
  • Remove header from BottomTab.Navigator
  • Wraps a set of stack screens into Stack.Group

Ticket Link

Closes #104

How has this been tested?

Played with the app a bit on iOS. There seem to be no regressions in the tabs and stack screens.

Screenshots

Checklist

  • Added a "Closes [issue number]" in the ticket link section
  • You have not changed whitespace unnecessarily (it makes diffs hard to read)
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens

@pedpess pedpess changed the title Feat/upgrade to react navigation v6 feat(react-navigation): upgrade to react navigation v6 Oct 6, 2021
@watadarkstar watadarkstar self-requested a review October 6, 2021 00:40
Copy link
Collaborator

@watadarkstar watadarkstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@watadarkstar watadarkstar merged commit 18bda17 into heylinda:main Oct 6, 2021
@watadarkstar
Copy link
Collaborator

Tested on iOS and Android - works like a charm! Nice work @pedpess I'll add you as a contributor so you can just branch off instead of working off a fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade react-navigation to v6
2 participants