fix: Block corruption when deleting block content using deleteLine command #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@heyman |
|
Hi! Sorry for not having time to look at this yet. Could you write a couple of tests? Look at |
|
I have implemented the tests. Can you please review it? |
|
I think this looks good! But perhaps we could move |
|
Sure thing, I'll go ahead and make that change. |
|
Done! Moved |
heyman
changed the title
|
Great, thanks! |
Maran1947
deleted the
bugfix/cell-corruption-when-deleting-block-contents
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #43
Solution approach #43(comment): Implemented a custom method that is block-aware which deletes the block when running on single line within block.