adapt to latest ex-aws #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Looks good, mind adding a quick test? |
ruslandoga
commented
Aug 31, 2021
| @@ -10,7 +10,7 @@ defmodule CloudWatchTest do | |||
| use ExUnit.Case, async: false | |||
|
|
|||
| setup_all do | |||
| {:ok, _} = Cycler.start_link() | |||
There was a problem hiding this comment.
I ran into a race condition when running tests locally where this match was failing here or in log_stream_name_test depending on which ran first since the tests don't wait for the cycler process to exit before running the next one.
ruslandoga
commented
Aug 31, 2021
| @@ -10,7 +10,7 @@ defmodule CloudWatchTest do | |||
| use ExUnit.Case, async: false | |||
|
|
|||
| setup_all do | |||
| {:ok, _} = Cycler.start_link() | |||
| start_supervised(Cycler) | |||
There was a problem hiding this comment.
This is the fix for the above. It makes the test wait for the cycler to exit before running the next test.
|
@kuiro5 I've added a test. |
|
@kuiro5 hi, sorry to bother again. I wonder if it would be possible to cut a release for current master? |
pmenhart
added a commit
to pmenhart/cloud_watch
that referenced
this pull request
Sep 3, 2021
|
@ruslandoga @msmithstubbs v0.4.1 released, apologies on the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #24