all: deal with t.Run

heyxkhoa · Feb 9, 2021 · 31cc29a · 31cc29a
1 parent 484f477
commit 31cc29a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/internal/stats/stats_test.go b/internal/stats/stats_test.go
@@ -148,7 +148,7 @@ func TestStatsCollector(t *testing.T) {
 
 	t.Run("hours", func(t *testing.T) {
 		statsData := statsCollector(units, 0, Hours, ng)
-		require.Len(t, statsData, 720)
+		assert.Len(t, statsData, 720)
 	})
 
 	t.Run("days", func(t *testing.T) {

diff --git a/internal/sysutil/net_linux_test.go b/internal/sysutil/net_linux_test.go
@@ -113,7 +113,9 @@ func TestSetStaticIPdhcpcdConf(t *testing.T) {
 	}}
 
 	for _, tc := range testCases {
-		s := updateStaticIPdhcpcdConf("wlan0", "192.168.0.2/24", tc.routers, net.IP{192, 168, 0, 2})
-		assert.Equal(t, tc.dhcpcdConf, s)
+		t.Run(tc.name, func(t *testing.T) {
+			s := updateStaticIPdhcpcdConf("wlan0", "192.168.0.2/24", tc.routers, net.IP{192, 168, 0, 2})
+			assert.Equal(t, tc.dhcpcdConf, s)
+		})
 	}
 }
diff --git a/internal/util/autohosts_test.go b/internal/util/autohosts_test.go
@@ -114,10 +114,8 @@ func TestAutoHostsFSNotify(t *testing.T) {
 	ah.Start()
 	t.Cleanup(ah.Close)
 
-	t.Run("file_update", func(t *testing.T) {
-		assertWriting(t, f, "127.0.0.2   newhost\n")
-		assert.Nil(t, f.Sync())
-	})
+	assertWriting(t, f, "127.0.0.2   newhost\n")
+	require.Nil(t, f.Sync())
 
 	// Wait until fsnotify has triggerred and processed the
 	// file-modification event.