stats: fix nil ptr deref

heyxkhoa · Aug 4, 2022 · 59a0f24 · 59a0f24
1 parent 7fc3ff1
commit 59a0f24
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/internal/stats/unit.go b/internal/stats/unit.go
@@ -632,6 +632,9 @@ func (s *StatsCtx) Update(e Entry) {
 	}
 
 	u := s.ongoing()
+	if u == nil {
+		return
+	}
 
 	u.mu.Lock()
 	defer u.mu.Unlock()
@@ -655,7 +658,12 @@ func (s *StatsCtx) loadUnits(limit uint32) ([]*unitDB, uint32) {
 	}
 
 	cur := s.ongoing()
-	curID := atomic.LoadUint32(&cur.id)
+	var curID uint32
+	if cur != nil {
+		curID = atomic.LoadUint32(&cur.id)
+	} else {
+		curID = s.unitIDGen()
+	}
 
 	// Per-hour units.
 	units := []*unitDB{}
@@ -671,7 +679,9 @@ func (s *StatsCtx) loadUnits(limit uint32) ([]*unitDB, uint32) {
 
 	_ = tx.Rollback()
 
-	units = append(units, cur.serialize())
+	if cur != nil {
+		units = append(units, cur.serialize())
+	}
 
 	if len(units) != int(limit) {
 		log.Fatalf("len(units) != limit: %d %d", len(units), limit)