fix: message list shouldn't get stuck loading #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
elisealix22
commented
Oct 28, 2022
neekolas
reviewed
Oct 28, 2022
neekolas
approved these changes
Oct 28, 2022
neekolas
reviewed
Oct 28, 2022
bigint
approved these changes
Oct 29, 2022
|
@elisealix22 can you please resolve the conflicts 🙏🏼 |
|
Resolved @bigint ! Sorry for the delay |
neekolas
approved these changes
Oct 30, 2022
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 Lenster Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes it so our
useGetConversationhook listens for updates toconversationssince it sets the selectedConversation based on the data in that store. This should fix sometimes there being a null selectedConversation which appeared like an endless loading state.It also polishes the missing xmtp auth UI for people who haven't enabled DMs yet.
Type of change
How should this be tested?