Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disambiguate sender in preview tile #1024

Merged
merged 1 commit into from
Oct 30, 2022
Merged

Conversation

saulmc
Copy link
Contributor

@saulmc saulmc commented Oct 30, 2022

What does this PR do?

Disambiguates the message sender in the preview tile by prepending "You: " if the message was sent by the current user. This design pattern is used in Twitter DMs and Signal.

CleanShot 2022-10-29 at 23 37 17@2x

Type of change

  • Enhancement (non-breaking small changes to existing functionality)

How should this be tested?

  • Send a message from Profile A to Profile B
  • As Profile A, confirm "You: " is seen before the message content in the message preview tile
  • Switch to Profile B
  • As Profile B, confirm "You: " is not seen before the message content in the message preview tile

@vercel
Copy link

vercel bot commented Oct 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lenster ✅ Ready (Inspect) Visit Preview Oct 30, 2022 at 6:39AM (UTC)

@bigint bigint merged commit 6bee0c6 into main Oct 30, 2022
@bigint bigint deleted the saulmc/prepend-you-if-sender branch October 30, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants