feat: redirect to first conversation in list #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bigint
changed the title
neekolas
changed the title
neekolas
changed the title
neekolas
changed the title
…z/lenster into auto-select-first-conversation
|
Can you please resolve the conflicts 🙏🏼 |
…o-select-first-conversation Conflicts: src/components/Messages/Message.tsx
|
@bigint resolved conflicts |
bigint
reviewed
Nov 1, 2022
| } | ||
|
|
||
| // Borrowed from https://usehooks.com/useWindowSize/ | ||
| const useWindowSize = (): Size => { |
There was a problem hiding this comment.
We can use tailwind's classes instead of this hook right?
There was a problem hiding this comment.
For styling, absolutely. But this is used to change behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
/messagesas a distinct route to show the conversation list)/messagesrouteI think this feature is going to get picked up in a planned refactor to merge the
Message.tsxandindex.tsxpages into a single route. Right now, the necessary information to execute this redirect is lower in the React tree than is ideal.I also had to add a new React hook to track the window width to avoid this behaviour on mobile, which is unfortunate. Open to other solutions that don't rely on
window.innerWidth.The PR also changes the send button to only icon in the mobile view and makes the mobile view flow start from 1024px
Fixes # (issue)
CleanShot.2022-10-31.at.10.47.47.mp4
Type of change
How should this be tested?
/messagespage on the desktop. The first conversation should be automatically selected once loading is complete/messagespage on mobile. The conversation list should appear, and it should be possible to navigate to the individual conversation and back.