Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove "This is the beginning of the conversation" flicker #1038

Merged
merged 2 commits into from
Nov 1, 2022

Conversation

neekolas
Copy link
Contributor

@neekolas neekolas commented Oct 31, 2022

What does this PR do?

  • The "This is the beginning of the conversation" text would flicker when the page was loaded. This changes around the behaviour of the hasMore property so that it doesn't toggle between true and false while the first page is loading.

Fixes # (issue)

CleanShot.2022-10-31.at.11.17.47.mp4

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Go to a conversation with more than 15 messages. Reload the page and scroll to the top. All messages should be displayed
  • Go to a conversation with more than 30 messages. Reload the page and scroll to the top. All messages should be displayed
  • Go to a conversation with less than 15 messages. There should be no flicker on the "This is the beginning of the conversation" text when loading.

@vercel
Copy link

vercel bot commented Oct 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lenster ✅ Ready (Inspect) Visit Preview Oct 31, 2022 at 6:23PM (UTC)

@neekolas neekolas changed the title Remove This is the beginning of the conversation flicker Remove "This is the beginning of the conversation" flicker Oct 31, 2022
@vercel vercel bot temporarily deployed to Preview October 31, 2022 18:23 Inactive
@neekolas neekolas changed the title Remove "This is the beginning of the conversation" flicker fix: remove "This is the beginning of the conversation" flicker Oct 31, 2022
@bigint bigint merged commit 9b9db59 into main Nov 1, 2022
@bigint bigint deleted the remove-flicker-from-this-is-the-beginning-of-convo branch November 1, 2022 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants