Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: redirect to first conversation #1078

Merged
merged 3 commits into from
Nov 3, 2022
Merged

revert: redirect to first conversation #1078

merged 3 commits into from
Nov 3, 2022

Conversation

neekolas
Copy link
Contributor

@neekolas neekolas commented Nov 2, 2022

What does this PR do?

  • No longer redirects to the first conversation in the list
  • Adds an empty state for the Messages page

Fixes # (issue)

CleanShot.2022-11-02.at.11.19.36.mp4

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Navigate to /messages on desktop. The empty state should be displayed and no redirect should happen

@neekolas neekolas requested a review from bigint as a code owner November 2, 2022 18:20
@vercel
Copy link

vercel bot commented Nov 2, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lenster ✅ Ready (Inspect) Visit Preview Nov 2, 2022 at 7:10PM (UTC)

elisealix22
elisealix22 approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@elisealix22 elisealix22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ Looks amazing! Nice touch on the empty state @darickdang !

@vercel vercel bot temporarily deployed to Preview November 2, 2022 19:10 Inactive
@bigint bigint changed the title Revert redirect to first conversation revert: redirect to first conversation Nov 3, 2022
@bigint bigint merged commit 073d63d into main Nov 3, 2022
@bigint bigint deleted the revert-redirect-to-first-conversation branch November 3, 2022 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elisealix22 elisealix22 elisealix22 approved these changes

@bigint bigint bigint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@neekolas @elisealix22 @bigint