Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: replace current text editor #1090

Merged
merged 52 commits into from
Nov 12, 2022
Merged

feat!: replace current text editor #1090

merged 52 commits into from
Nov 12, 2022

Conversation

harish-sethuraman
Copy link
Contributor

@harish-sethuraman harish-sethuraman commented Nov 3, 2022 •
edited
Loading

What does this PR do?

Replaces current text editor with new one

Screen.Recording.2022-11-04.at.1.40.38.AM.mov

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • test new changes features
  • test existing texts as well

@vercel
Copy link

vercel bot commented Nov 3, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lenster ✅ Ready (Inspect) Visit Preview Nov 12, 2022 at 0:09AM (UTC)

@harish-sethuraman harish-sethuraman marked this pull request as draft November 3, 2022 20:09
@vercel vercel bot temporarily deployed to Preview November 3, 2022 20:12 Inactive
@bigint bigint changed the title feat!: replace current text editor feat: replace current text editor Nov 4, 2022
@vercel vercel bot temporarily deployed to Preview November 4, 2022 02:55 Inactive
@bigint bigint changed the title feat: replace current text editor feat!: replace current text editor Nov 5, 2022
@vercel vercel bot temporarily deployed to Preview November 5, 2022 10:20 Inactive
@vercel vercel bot temporarily deployed to Preview November 5, 2022 10:22 Inactive
@vercel vercel bot temporarily deployed to Preview November 5, 2022 16:03 Inactive
@bigint bigint added this to the v1.0.4-beta milestone Nov 5, 2022
@vercel vercel bot temporarily deployed to Preview November 5, 2022 16:12 Inactive
@vercel vercel bot temporarily deployed to Preview November 5, 2022 16:15 Inactive
@vercel vercel bot temporarily deployed to Preview November 12, 2022 07:43 Inactive
@vercel vercel bot temporarily deployed to Preview November 12, 2022 07:49 Inactive
@vercel vercel bot temporarily deployed to Preview November 12, 2022 08:07 Inactive
@vercel vercel bot temporarily deployed to Preview November 12, 2022 08:09 Inactive
@bigint bigint marked this pull request as ready for review November 12, 2022 10:00
@vercel vercel bot temporarily deployed to Preview November 12, 2022 11:02 Inactive
@vercel vercel bot temporarily deployed to Preview November 12, 2022 11:23 Inactive
@vercel vercel bot temporarily deployed to Preview November 12, 2022 11:35 Inactive
bigint
bigint approved these changes Nov 12, 2022
View reviewed changes
Copy link
Member

@bigint bigint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @harish-sethuraman 🖖🏼

LGTM :shipit:

Rad LGTM

@vercel vercel bot temporarily deployed to Preview November 12, 2022 11:46 Inactive
@bigint bigint enabled auto-merge (squash) November 12, 2022 12:08
@vercel vercel bot temporarily deployed to Preview November 12, 2022 12:09 Inactive
@bigint bigint merged commit 65067c9 into main Nov 12, 2022
@bigint bigint deleted the add-new-editor branch November 12, 2022 12:09
@gitpoap-bot
Copy link

gitpoap-bot bot commented Nov 12, 2022

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 Lenster Contributor:

GitPOAP: 2022 Lenster Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigint bigint bigint approved these changes

Assignees

@harish-sethuraman harish-sethuraman

@bigint bigint

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@harish-sethuraman @bigint