fix: break up profiles into batches of 50 #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2 tasks
bigint
reviewed
Nov 4, 2022
Comment on lines
+70
to
+73
| apolloClient.query({ | ||
| query: ProfilesDocument, | ||
| variables: { request: { profileIds: profileIdChunk } } | ||
| }) |
There was a problem hiding this comment.
question: I think we can use useLazyQuery hook here 🤔, if we use apolloClient all the apollo config will not be applied here
|
Merging this now, cuz its breaking prod 🙏🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
profileIds. So, we are breaking the request into smaller chunks.Fixes # (issue)
CleanShot.2022-11-03.at.13.45.18.mp4
Type of change
How should this be tested?
MAX_PROFILES_TO_LOAD_CONCURRENTLYvariable)