fix: stop click propagation for open original (#1176) #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@foolo is attempting to deploy a commit to the Lenster Team on Vercel. A member of the Team first needs to authorize it. |
bigint
approved these changes
Nov 14, 2022
|
Amazing 🤩 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1176
Fix the previous behavior which was that "Open original" opened both the original media and the corresponding post.
Type of change
How should this be tested?
In the feed, find a post which has an image
Click the image. Image will show in full size, with a link "Open original"
Click "Open original"
Verify that the original is opened in a new tab, and that nothing happens in the original tab (should not open the post)