Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: see through lens #1265

Merged
merged 9 commits into from
Nov 22, 2022
Merged

feat: see through lens #1265

merged 9 commits into from
Nov 22, 2022

Conversation

sasicodes
Copy link
Contributor

@sasicodes sasicodes commented Nov 21, 2022 •
edited
Loading

What does this PR do?

Fixes #1053

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't performed a self-review of my own code and corrected any misspellings
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Nov 21, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
web ✅ Ready (Inspect) Visit Preview Nov 22, 2022 at 6:21PM (UTC)
1 Ignored Deployment
Name Status Preview Updated
api ⬜️ Ignored (Inspect) Nov 22, 2022 at 6:21PM (UTC)

@sasicodes sasicodes self-assigned this Nov 21, 2022
@bigint
Copy link
Member

bigint commented Nov 22, 2022

Good to merge @sasicodes?

@bigint
Copy link
Member

bigint commented Nov 22, 2022

@sasicodes With who?

@vercel vercel bot temporarily deployed to Preview – api November 22, 2022 12:26 Inactive
@bigint
Copy link
Member

bigint commented Nov 22, 2022 •
edited
Loading

image

padding right and left looks different 🤔

Should be same as right

bigint
bigint requested changes Nov 22, 2022
View reviewed changes
apps/web/src/store/timeline.ts Outdated Show resolved Hide resolved
apps/web/src/store/timeline.ts Outdated Show resolved Hide resolved
apps/web/src/components/Home/Timeline/index.tsx Show resolved Hide resolved
apps/web/src/components/Home/SeeThroughLens.tsx Outdated Show resolved Hide resolved
apps/web/src/components/Home/SeeThroughLens.tsx Outdated Show resolved Hide resolved
@bigint bigint merged commit 6cd265b into main Nov 22, 2022
@bigint bigint deleted the c-through-lens branch November 22, 2022 18:24
bigint added a commit that referenced this pull request Nov 22, 2022
@bigint
Revert "feat: see through lens (#1265)"
cc2e444 
This reverts commit 6cd265b.
@bigint bigint mentioned this pull request Nov 22, 2022
Merged
@bigint bigint restored the c-through-lens branch November 22, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigint bigint bigint requested changes

Assignees

@sasicodes sasicodes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

See the feed through the lens of someone else
2 participants
@sasicodes @bigint