Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: copy and paste photos #1397

Merged
merged 20 commits into from
Dec 14, 2022
Merged

feat: copy and paste photos #1397

merged 20 commits into from
Dec 14, 2022

Conversation

hungds99
Copy link
Contributor

@hungds99 hungds99 commented Dec 11, 2022 •
edited by bigint

What does this PR do?

Fixes #1376

https://www.loom.com/share/7de133e249e14da7a8597a10a80fd003

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't performed a self-review of my own code and corrected any misspellings
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Dec 11, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
api ✅ Ready (Inspect) Visit Preview Dec 14, 2022 at 3:08AM (UTC)
pro ✅ Ready (Inspect) Visit Preview Dec 14, 2022 at 3:08AM (UTC)
web ✅ Ready (Inspect) Visit Preview Dec 14, 2022 at 3:08AM (UTC)

@vercel vercel bot temporarily deployed to Preview – api December 11, 2022 16:39 Inactive
@vercel vercel bot temporarily deployed to Preview – pro December 11, 2022 16:40 Inactive
@vercel vercel bot temporarily deployed to Preview – api December 11, 2022 16:41 Inactive
@vercel vercel bot temporarily deployed to Preview – pro December 11, 2022 16:43 Inactive
@vercel vercel bot temporarily deployed to Preview – api December 11, 2022 17:12 Inactive
@vercel vercel bot temporarily deployed to Preview – pro December 11, 2022 17:13 Inactive
@vercel vercel bot temporarily deployed to Preview – api December 11, 2022 17:22 Inactive
@vercel vercel bot temporarily deployed to Preview – pro December 11, 2022 17:22 Inactive
@bigint
Copy link
Member

bigint commented Dec 11, 2022 •
edited

Can we also optimistically inject images (immediately after pasting/choosing)? like twitter does 🙇🏼

Will increase the bounty to 180 USD 🚀

WDYT @hungds99 🙇🏼

@vercel vercel bot temporarily deployed to Preview – api December 12, 2022 13:32 Inactive
@vercel vercel bot temporarily deployed to Preview – api December 13, 2022 00:52 Inactive
@bigint
Copy link
Member

bigint commented Dec 13, 2022

@hungds99 ci is failing 🙇🏼

@vercel vercel bot temporarily deployed to Preview – api December 13, 2022 07:55 Inactive
@vercel vercel bot temporarily deployed to Preview – api December 13, 2022 08:12 Inactive
@hungds99
Copy link
Contributor Author

@hungds99 ci is failing 🙇🏼

@bigint I fixed

@vercel vercel bot temporarily deployed to Preview – api December 13, 2022 14:42 Inactive
@vercel vercel bot temporarily deployed to Preview – api December 13, 2022 14:45 Inactive
@vercel vercel bot temporarily deployed to Preview – api December 13, 2022 15:34 Inactive
@vercel vercel bot temporarily deployed to Preview – api December 14, 2022 03:03 Inactive
bigint
bigint approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@bigint bigint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Rad LGTM

@bigint
Copy link
Member

bigint commented Dec 14, 2022

Thanks for shipping great feature @hungds99 🚀

Sending bounty ASAP

@bigint bigint enabled auto-merge (squash) December 14, 2022 03:07
@bigint bigint merged commit 324c405 into heyxyz:main Dec 14, 2022
@vercel vercel bot temporarily deployed to Preview – api December 14, 2022 03:08 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harish-sethuraman harish-sethuraman harish-sethuraman left review comments

@bigint bigint bigint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Photos copy & paste
3 participants
@hungds99 @bigint @harish-sethuraman